Bug 168261 - Call WKDestroyRenderingResources() on iOS when tabs are backgrounded
Summary: Call WKDestroyRenderingResources() on iOS when tabs are backgrounded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-13 15:46 PST by Simon Fraser (smfr)
Modified: 2017-02-13 16:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2017-02-13 15:48 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (7.11 KB, patch)
2017-02-13 16:14 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-13 15:46:14 PST 
Call WKDestroyRenderingResources() on iOS when tabs are backgrounded
Comment 1 Simon Fraser (smfr) 2017-02-13 15:48:18 PST 
Created attachment 301404 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-02-13 15:48:48 PST 
rdar://problem/30481079
Comment 3 Simon Fraser (smfr) 2017-02-13 16:14:13 PST 
Created attachment 301410 [details]
Patch
Comment 4 Tim Horton 2017-02-13 16:15:59 PST 
Comment on attachment 301404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301404&action=review

> Source/WebKit2/ChangeLog:9
> +        There's code to call WKDestroyRenderingResources() on a 10s timer that exists for Mac, but on iOS

Please unWKSI this.

> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:446
> +    RELEASE_LOG(ProcessSuspension, "%p - WebProcess::destroyRenderingResources() took %.2fms", this, (endTime - startTime) * 1000.0);

Would be neat if we had a thing for this.
Comment 5 WebKit Commit Bot 2017-02-13 16:16:19 PST 
Attachment 301410 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:35:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2017-02-13 16:49:20 PST 
Comment on attachment 301410 [details]
Patch

Clearing flags on attachment: 301410

Committed r212260: <http://trac.webkit.org/changeset/212260>
Comment 7 WebKit Commit Bot 2017-02-13 16:49:25 PST 
All reviewed patches have been landed.  Closing bug.