WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168214
[GTK] Improve documentation of webkit_context_menu_set_user_data()
https://bugs.webkit.org/show_bug.cgi?id=168214
Summary
[GTK] Improve documentation of webkit_context_menu_set_user_data()
Michael Catanzaro
Reported
2017-02-12 19:11:14 PST
Improve documentation of webkit_context_menu_set_user_data()
Attachments
Patch
(1.39 KB, patch)
2017-02-12 19:12 PST
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2017-02-12 19:12:17 PST
Created
attachment 301327
[details]
Patch
WebKit Commit Bot
Comment 2
2017-02-12 19:14:05 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3
2017-02-12 22:24:10 PST
Comment on
attachment 301327
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=301327&action=review
> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.cpp:336 > + * If the @user_data #GVariant is floating, it is consumed.
I think this is expected with floating objects, but it doesn't hurt to clarify it here anyway.
WebKit Commit Bot
Comment 4
2017-02-12 22:48:59 PST
Comment on
attachment 301327
[details]
Patch Clearing flags on attachment: 301327 Committed
r212225
: <
http://trac.webkit.org/changeset/212225
>
WebKit Commit Bot
Comment 5
2017-02-12 22:49:05 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug