Bug 168214 - [GTK] Improve documentation of webkit_context_menu_set_user_data()
Summary: [GTK] Improve documentation of webkit_context_menu_set_user_data()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Trivial
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-12 19:11 PST by Michael Catanzaro
Modified: 2017-02-12 22:49 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2017-02-12 19:12 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-02-12 19:11:14 PST 
Improve documentation of webkit_context_menu_set_user_data()
Comment 1 Michael Catanzaro 2017-02-12 19:12:17 PST 
Created attachment 301327 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-12 19:14:05 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2017-02-12 22:24:10 PST 
Comment on attachment 301327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301327&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.cpp:336
> + * If the @user_data #GVariant is floating, it is consumed.

I think this is expected with floating objects, but it doesn't hurt to clarify it here anyway.
Comment 4 WebKit Commit Bot 2017-02-12 22:48:59 PST 
Comment on attachment 301327 [details]
Patch

Clearing flags on attachment: 301327

Committed r212225: <http://trac.webkit.org/changeset/212225>
Comment 5 WebKit Commit Bot 2017-02-12 22:49:05 PST 
All reviewed patches have been landed.  Closing bug.