Bug 168209 - Web Inspector: expose system user interface layout direction through InspectorFrontendHost
Summary: Web Inspector: expose system user interface layout direction through Inspecto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-12 14:26 PST by Brian Burg
Modified: 2017-02-13 18:30 PST (History)
5 users (show)

See Also:


Attachments
Proposed Fix (10.45 KB, patch)
2017-02-12 14:32 PST, Brian Burg
joepeck: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-02-12 14:26:36 PST
We already know this in WK2, just plumb it through to the frontend.
Comment 1 Brian Burg 2017-02-12 14:26:51 PST
<rdar://problem/11573736>
Comment 2 Brian Burg 2017-02-12 14:32:22 PST
Created attachment 301318 [details]
Proposed Fix
Comment 3 Joseph Pecoraro 2017-02-13 18:02:16 PST
Comment on attachment 301318 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=301318&action=review

r=me

> Source/WebCore/inspector/InspectorFrontendHost.h:2
> + * Copyright (C) 2007, 2017 Apple Inc. All rights reserved.

Nit: 2007-2017 I think is the new way to avoid endless commas. (here and elsewhere)

> Source/WebCore/inspector/InspectorFrontendHost.idl:45
> +    DOMString userInterfaceLayoutDirection();

I'd expect an InspectorFrontendHostStub implementation of this.
Comment 4 Brian Burg 2017-02-13 18:30:38 PST
Committed r212272: <http://trac.webkit.org/changeset/212272>