Bug 16817 - [Gtk] Menu items need underscores
Summary: [Gtk] Menu items need underscores
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Major
Assignee: Christian Dywan
Keywords: Gtk
Depends on:
Reported: 2008-01-10 09:51 PST by Christian Dywan
Modified: 2008-01-11 16:26 PST (History)
0 users

See Also:

Add underscores to appropriate menu labels. (10.58 KB, patch)
2008-01-11 04:21 PST, Christian Dywan
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2008-01-10 09:51:33 PST
WebKitGtk should use underscores in menu items.
Comment 1 Christian Dywan 2008-01-11 04:21:09 PST
Created attachment 18388 [details]
Add underscores to appropriate menu labels.

This patch adds underscores to all appropriate menu labels.

-    return String::fromUTF8(_("No file selected"));
+    return String::fromUTF8(_("(None)"));

I changed this to match GtkFileChooserButton.

-    return String::fromUTF8(_("Search with MSN"));
+    return String::fromUTF8(_("_Search the Web"));

I changed this because I don't think a random search engine provider is very useful in a generic item.
Comment 2 Alp Toker 2008-01-11 16:24:55 PST
Comment on attachment 18388 [details]
Add underscores to appropriate menu labels.


Will add a couple more string fixes we noticed before landing.
Comment 3 Alp Toker 2008-01-11 16:26:04 PST
Landed in r29422.