Bug 168159 – [WK2] Add test infrastructure and unit tests for data interaction

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

Build infrastructure to be able to test data interaction.

[Wenson Hsieh]

<rdar://problem/30477634>

[Wenson Hsieh]

Created attachment 301239 [details]
Patch

[Wenson Hsieh]

Created attachment 301242 [details]
Build fix

[Wenson Hsieh]

Created attachment 301323 [details]
Add another test case

[Tim Horton]

Comment on attachment 301323 [details]
Add another test case

View in context: https://bugs.webkit.org/attachment.cgi?id=301323&action=review

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:57
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

ADOPT

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:70
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

ADOPT

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:84
> +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];

ADOPT

[Wenson Hsieh]

Created attachment 301391 [details]
Patch for landing

[Wenson Hsieh]

(In reply to comment #5)
> Comment on attachment 301323 [details]
> Add another test case
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301323&action=review
> 
> > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:57
> > +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];
> 
> ADOPT

Whoops, good catch. Fixed!

> 
> > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:70
> > +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];
> 
> ADOPT
> 
> > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:84
> > +        RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)];
> 
> ADOPT

[WebKit Commit Bot]

Comment on attachment 301391 [details]
Patch for landing

Rejecting attachment 301391 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 301391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
bKit2Cocoa/image-and-contenteditable.html
patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html
patching file Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
patching file Tools/TestWebKitAPI/ios/DataInteractionSimulator.h
patching file Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3081168

[Wenson Hsieh]

Created attachment 301393 [details]
Patch for landing

[Wenson Hsieh]

Comment on attachment 301391 [details]
Patch for landing

Needed rebasing.

[WebKit Commit Bot]

Comment on attachment 301393 [details]
Patch for landing

Clearing flags on attachment: 301393

Committed r212254: <http://trac.webkit.org/changeset/212254>