Bug 168147 – Add new WKWebKit Cocoa API for getContentsAsString

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Jason Rinn]

Add new WKWebKit Cocoa API for getContentsAsString

[Jason Rinn]

Created attachment 301407 [details]
Patch

[Tim Horton]

Comment on attachment 301407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301407&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3807
> +    auto handler = adoptNS([completionHandler copy]);

This should probably use BlockPtr these days.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3813
> +            RetainPtr<NSError> error = adoptNS([[NSError alloc] init]);

This actually logs an error, and the other uses (of [[NSError alloc] init]) are wrong. Should we fix it? Or just propagate the wrongness.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm:42
> +    NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
> +    [webView loadRequest:request];
> +    [webView _test_waitForDidFinishNavigation];

If you want, if you use the TestWKWebView subclass instead of WKWebView directly, it has synchronouslyLoadTestPageNamed, which will replace all of these lines.

[Radar WebKit Bug Importer]

<rdar://problem/30502539>

[Tim Horton]

Comment on attachment 301407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301407&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:229
> +- (void)_getContentsAsStringWithCompletionHandler:(void (^)(NSString *, NSError *))completionHandler;

Also, Dan points out that you've forgotten your API availability macros.

[Tim Horton]

(In reply to comment #4)
> Comment on attachment 301407 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301407&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:229
> > +- (void)_getContentsAsStringWithCompletionHandler:(void (^)(NSString *, NSError *))completionHandler;
> 
> Also, Dan points out that you've forgotten your API availability macros.

Like this: WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA))

[Jason Rinn]

Created attachment 301434 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 301434 [details]
Patch

Clearing flags on attachment: 301434

Committed r212334: <http://trac.webkit.org/changeset/212334>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.