WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168103
Mail hangs when removing multiple rows from large table.
https://bugs.webkit.org/show_bug.cgi?id=168103
Summary
Mail hangs when removing multiple rows from large table.
alan baradlay
Reported
2017-02-09 20:49:00 PST
Created
attachment 301126
[details]
Test case
rdar://problem/30090186
Attachments
Test case
(21.02 KB, text/html)
2017-02-09 20:49 PST
,
alan baradlay
no flags
Details
Patch
(29.69 KB, patch)
2017-02-09 21:13 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews112 for mac-elcapitan
(2.43 MB, application/zip)
2017-02-09 22:52 PST
,
Build Bot
no flags
Details
Patch
(29.17 KB, patch)
2017-02-10 12:19 PST
,
alan baradlay
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
alan baradlay
Comment 1
2017-02-09 21:13:28 PST
Created
attachment 301127
[details]
Patch
Ryosuke Niwa
Comment 2
2017-02-09 21:40:49 PST
Comment on
attachment 301127
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=301127&action=review
> Source/WebCore/editing/DeleteSelectionCommand.cpp:395 > - removeNode(remove, shouldAssumeContentIsAlwaysEditable); > + removeNode(remove, shouldAssumeContentIsAlwaysEditable, LayoutTiming::Delayed);
Instead of adding a new flag like this. We should be able to directly call CompositeEditCommand's removeNode with the code below if (node == m_startBlock...) So I think it's better if we extracted a new helper function e.g. removeNodeUpdatingStates that we call here instead of using a mutual recursion with a different flag. r=me with that change.
Build Bot
Comment 3
2017-02-09 22:52:33 PST
Comment on
attachment 301127
[details]
Patch
Attachment 301127
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/3058047
New failing tests: editing/execCommand/indent-right-after-table.html editing/deleting/5433862-1.html editing/execCommand/5658933-1.html editing/execCommand/5481523.html editing/execCommand/delete-table-with-empty-contents.html editing/deleting/4922367.html editing/execCommand/format-block-table.html editing/execCommand/5144139-1.html editing/deleting/5206311-2.html editing/execCommand/indent-partial-table.html editing/deleting/5206311-1.html editing/execCommand/5483526.html
Build Bot
Comment 4
2017-02-09 22:52:37 PST
Created
attachment 301134
[details]
Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
alan baradlay
Comment 5
2017-02-10 12:19:55 PST
Created
attachment 301193
[details]
Patch
WebKit Commit Bot
Comment 6
2017-02-10 14:37:47 PST
Comment on
attachment 301193
[details]
Patch Clearing flags on attachment: 301193 Committed
r212151
: <
http://trac.webkit.org/changeset/212151
>
WebKit Commit Bot
Comment 7
2017-02-10 14:37:52 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug