Bug 168098 - Improve IOSurfacePool logging
Summary: Improve IOSurfacePool logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-09 19:41 PST by Simon Fraser (smfr)
Modified: 2017-02-09 21:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2017-02-09 19:42 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-09 19:41:50 PST 
Improve IOSurfacePool logging
Comment 1 Simon Fraser (smfr) 2017-02-09 19:42:34 PST 
Created attachment 301120 [details]
Patch
Comment 2 Sam Weinig 2017-02-09 20:01:23 PST 
Comment on attachment 301120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301120&action=review

> Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:44
> +#define ENABLE_IOSURFACE_POOL_STATISTICS 1

Do you really want to define this to 1?
Comment 3 Simon Fraser (smfr) 2017-02-09 20:12:36 PST 
Comment on attachment 301120 [details]
Patch

I don't, no. Ignore that line.
Comment 4 Tim Horton 2017-02-09 20:18:14 PST 
Comment on attachment 301120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301120&action=review

> Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:177
> +    WTFLogAlways("IOSurfacePool::addSurface %p (should cache %d) m_maximumBytesCached=%lu", surface.get(), shouldCacheSurface(*surface), m_maximumBytesCached);

I don't think you meant to WTFLogAlways here?
Comment 5 Simon Fraser (smfr) 2017-02-09 21:28:59 PST 
https://trac.webkit.org/r212043