RESOLVED FIXED 168098
Improve IOSurfacePool logging 
https://bugs.webkit.org/show_bug.cgi?id=168098
Summary Improve IOSurfacePool logging
Simon Fraser (smfr)
Reported 2017-02-09 19:41:50 PST
Improve IOSurfacePool logging
Attachments
Patch (7.25 KB, patch)
2017-02-09 19:42 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-02-09 19:42:34 PST
Created attachment 301120 [details] Patch
Sam Weinig
Comment 2 2017-02-09 20:01:23 PST
Comment on attachment 301120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301120&action=review > Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:44 > +#define ENABLE_IOSURFACE_POOL_STATISTICS 1 Do you really want to define this to 1?
Simon Fraser (smfr)
Comment 3 2017-02-09 20:12:36 PST
Comment on attachment 301120 [details] Patch I don't, no. Ignore that line.
Tim Horton
Comment 4 2017-02-09 20:18:14 PST
Comment on attachment 301120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301120&action=review > Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:177 > + WTFLogAlways("IOSurfacePool::addSurface %p (should cache %d) m_maximumBytesCached=%lu", surface.get(), shouldCacheSurface(*surface), m_maximumBytesCached); I don't think you meant to WTFLogAlways here?
Simon Fraser (smfr)
Comment 5 2017-02-09 21:28:59 PST
https://trac.webkit.org/r212043
Note You need to log in before you can comment on or make changes to this bug.