Bug 168095 - Web Automation: fail gracefully when a screenshot cannot be encoded as base64
Summary: Web Automation: fail gracefully when a screenshot cannot be encoded as base64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-09 17:13 PST by BJ Burg
Modified: 2017-02-10 09:27 PST (History)
5 users (show)

See Also:

Attachments
Proposed Fix (4.95 KB, patch)
2017-02-09 22:27 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-02-09 17:13:52 PST 
<rdar://problem/30297427>
Comment 1 BJ Burg 2017-02-09 22:27:07 PST 
Created attachment 301133 [details]
Proposed Fix
Comment 2 Joseph Pecoraro 2017-02-09 22:32:01 PST 
Comment on attachment 301133 [details]
Proposed Fix

r=me. When can we not base64? Could we write a test for this?
Comment 3 BJ Burg 2017-02-10 09:01:30 PST 
(In reply to comment #2)
> Comment on attachment 301133 [details]
> Proposed Fix
> 
> r=me. When can we not base64? Could we write a test for this?

Unsure of how to reproduce this, but we have seen some crash reports to suggest it could happen. My guess is that the screenshot is too big to fit in memory for some reason–large web page or low memory or both.
Comment 4 WebKit Commit Bot 2017-02-10 09:27:10 PST 
Comment on attachment 301133 [details]
Proposed Fix

Clearing flags on attachment: 301133

Committed r212115: <http://trac.webkit.org/changeset/212115>
Comment 5 WebKit Commit Bot 2017-02-10 09:27:13 PST 
All reviewed patches have been landed.  Closing bug.