Bug 168080 - Add mediaStreamEnabled property to WKWebViewConfiguration
Summary: Add mediaStreamEnabled property to WKWebViewConfiguration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-09 15:01 PST by Andrew Gold
Modified: 2017-02-10 15:56 PST (History)
6 users (show)

See Also:

Attachments
proposed patch (3.36 KB, patch)
2017-02-09 15:50 PST, Andrew Gold 		no flags Details | Formatted Diff | Diff
proposed patch v2 (6.27 KB, patch)
2017-02-10 15:24 PST, Andrew Gold 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gold 2017-02-09 15:01:32 PST 
Add the ability to enable media stream to the Cocoa API.
Comment 1 Andrew Gold 2017-02-09 15:50:36 PST 
Created attachment 301094 [details]
proposed patch
Comment 2 Tim Horton 2017-02-10 10:43:31 PST 
Comment on attachment 301094 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301094&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:70
> +@property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

Is this the kind of feature that you would want to toggle dynamically? Is it even possible to toggle it dynamically? Otherwise it belongs in WKWebViewConfiguration.
Comment 3 Tim Horton 2017-02-10 10:43:45 PST 
Also, gotta set r?
Comment 4 Andrew Gold 2017-02-10 15:23:33 PST 
Title updated based off of Tim's feedback.
Comment 5 Andrew Gold 2017-02-10 15:24:54 PST 
Created attachment 301201 [details]
proposed patch v2
Comment 6 WebKit Commit Bot 2017-02-10 15:56:49 PST 
Comment on attachment 301201 [details]
proposed patch v2

Clearing flags on attachment: 301201

Committed r212163: <http://trac.webkit.org/changeset/212163>
Comment 7 WebKit Commit Bot 2017-02-10 15:56:53 PST 
All reviewed patches have been landed.  Closing bug.