Bug 168078 - cleanup WebLocalizableStrings
Summary: cleanup WebLocalizableStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-09 14:20 PST by Aakash Jain
Modified: 2017-02-10 13:26 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (10.34 KB, patch)
2017-02-09 14:23 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (10.85 KB, patch)
2017-02-09 14:27 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (1.40 KB, patch)
2017-02-10 11:46 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-09 14:20:39 PST 
mac/Misc/WebLocalizableStrings.mm seems to be unused and mac/Misc/WebLocalizableStrings.h seems to have unused methods. We should clean it up.
Comment 1 Aakash Jain 2017-02-09 14:23:16 PST 
Created attachment 301084 [details]
Proposed patch
Comment 2 Aakash Jain 2017-02-09 14:27:30 PST 
Created attachment 301086 [details]
Updated patch
Comment 3 Alex Christensen 2017-02-09 17:19:36 PST 
Comment on attachment 301086 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301086&action=review

> Source/WebKit/mac/Misc/WebLocalizableStrings.h:51
> +__attribute__((visibility("hidden")))

Exporting in WebCore uses something like this (WEBCORE_EXPORT).  Exporting in WebKit uses WebKit.exp right now, so this won't change anything.
Comment 4 Aakash Jain 2017-02-10 11:46:17 PST 
Created attachment 301187 [details]
Updated patch

WebLocalizedStringWithValue is actually used in other frameworks, so it can't be deleted. Simplified the patch. We need visibility hidden for WebLocalizableStringsBundle as it's for each framework's own consumption, and never needs to be exported. Few other tools also require the header file to export only what is required.
Comment 5 Alexey Proskuryakov 2017-02-10 12:28:37 PST 
> Exporting in WebCore uses something like this (WEBCORE_EXPORT).  Exporting in WebKit uses WebKit.exp right now, so this won't change anything.

This is an SPI header, and the expectation is that all symbols in API/SPI headers are also available to link against.
Comment 6 WebKit Commit Bot 2017-02-10 13:26:18 PST 
Comment on attachment 301187 [details]
Updated patch

Clearing flags on attachment: 301187

Committed r212143: <http://trac.webkit.org/changeset/212143>
Comment 7 WebKit Commit Bot 2017-02-10 13:26:22 PST 
All reviewed patches have been landed.  Closing bug.