Bug 168058 – Remove usused header WebResourceLoadDelegatePrivate.h

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit Misc.

[Aakash Jain]

WebResourceLoadDelegatePrivate.h header is never used. It should be deleted.

[Aakash Jain]

Created attachment 301057 [details]
Proposed patch

[Aakash Jain]

Created attachment 301060 [details]
Updated patch

[Alexey Proskuryakov]

This seems like it should be fine, but having an entirely unimplemented category so surprising that maybe I'm missing something. Deferring review to others.

(In reply to comment #0)
> WebResourceLoadDelegatePrivate.h header is never used. It should be deleted.

This header declares an informal protocol. We have code to send at least some of the messages in the protocol to the delegate, and there are SPI clients that implement at least some of the delegate methods. Even if all of these things happen to work without the header, it seems like it should be there to serve as documentation and to allow WebKit to compile with stricter options (which forbid @selector with an unknown selector).

[Aakash Jain]

In that case, would it be fine to make it a project header instead of private header?

(In reply to comment #5)
> In that case, would it be fine to make it a project header instead of
> private header?

This is part of the private client interface. I don’t think it’s right to hide it unless we have a very good reason. Someone working on one of the clients may wonder why their source code includes an implementation of one of those methods, and being able to find the declaration in the SDK is useful in that case.

[Alexey Proskuryakov]

Would switching to @protocol make sense?

(In reply to comment #7)
> Would switching to @protocol make sense?

It would improve the API, but it’s a source-breaking change, so it would require some Apple-internal process.

[Aakash Jain]

ok. did another change in https://bugs.webkit.org/show_bug.cgi?id=168096 to fix the WebResourceLoadDelegatePrivate.h