Bug 168041 – [EME] Implement MediaKeySession::load()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Zan Dobersek]

SSIA.

[Zan Dobersek]

Created attachment 301032 [details]
Patch

[Build Bot]

Comment on attachment 301032 [details]
Patch

Attachment 301032 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3045833

New failing tests:
media/encrypted-media/mock-MediaKeySession-load.html

[Build Bot]

Created attachment 301037 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Xabier Rodríguez Calvar]

Comment on attachment 301032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301032&action=review

> Source/WebCore/Modules/encryptedmedia/CDM.cpp:658
> +    if (!m_private)
> +        return std::nullopt;
> +    return m_private->sanitizeSessionId(sessionId);

You might want to use (or not) ? :

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:249
> +    // 5. If the result of running the Is persistent session type? algorithm on this object's session type is false, return a promise rejected with a newly created TypeError.

I love this spec algorithm :)

> Source/WebCore/testing/MockCDMFactory.cpp:207
> +    if (equalLettersIgnoringASCIICase(sessionId, "valid-loaded-session"))
> +        return sessionId;
> +    return std::nullopt;

? : if you feel like

[Build Bot]

Comment on attachment 301032 [details]
Patch

Attachment 301032 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3045828

New failing tests:
media/encrypted-media/mock-MediaKeySession-load.html

[Build Bot]

Created attachment 301039 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301032 [details]
Patch

Attachment 301032 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3046652

New failing tests:
media/encrypted-media/mock-MediaKeySession-load.html

[Build Bot]

Created attachment 301040 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Zan Dobersek]

Comment on attachment 301032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301032&action=review

>> Source/WebCore/testing/MockCDMFactory.cpp:207
>> +    return std::nullopt;
> 
> ? : if you feel like

I tried following the style that was already in use in this file.

[Zan Dobersek]

Created attachment 301054 [details]
Patch for landing

[Zan Dobersek]

Landed in r212110.
https://trac.webkit.org/changeset/212110