RESOLVED FIXED 168039
[EME] Implement MediaKeySession::sessionClosed() 
https://bugs.webkit.org/show_bug.cgi?id=168039
Summary [EME] Implement MediaKeySession::sessionClosed()
Zan Dobersek
Reported 2017-02-09 00:07:42 PST
SSIA.
Attachments
Patch (13.80 KB, patch)
2017-02-09 00:27 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (15.17 KB, patch)
2017-02-09 07:04 PST, Zan Dobersek 		calvaris: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-02-09 00:27:00 PST
Created attachment 301021 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-02-09 05:20:58 PST
Comment on attachment 301021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301021&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:525 > + // 5. Let promise be the closed attribute of the session. > + // 6. Resolve promise. > + if (m_closedPromise) > + m_closedPromise->resolve(); These lines make me think a lot given that m_closedPromise is created when the JS closed attribute is accessed. So for this to work we would have to access closed so that the promise can be ever resolved. If the run this algorithm before accessing closed from JS we will be returning an unresolved promise that should be resolved already. I think we need to change the strategy. We need to have the promise created in advance and get it from the JS getter. Actually, please update the tests to test this situation this too.
Zan Dobersek
Comment 3 2017-02-09 07:04:02 PST
Created attachment 301034 [details] Patch
Zan Dobersek
Comment 4 2017-02-10 02:33:33 PST
Committed r212109: <http://trac.webkit.org/changeset/212109>
Note You need to log in before you can comment on or make changes to this bug.