Bug 168035 - Put names on more UIViews for ease of debugging
Summary: Put names on more UIViews for ease of debugging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 21:08 PST by Simon Fraser (smfr)
Modified: 2017-02-08 21:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.87 KB, patch)
2017-02-08 21:09 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-08 21:08:21 PST 
Put names on more UIViews for ease of debugging
Comment 1 Simon Fraser (smfr) 2017-02-08 21:09:03 PST 
Created attachment 301012 [details]
Patch
Comment 2 Tim Horton 2017-02-08 21:18:46 PST 
Comment on attachment 301012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301012&action=review

> Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:211
>      m_liveSwipeViewClippingView = adoptNS([[UIView alloc] initWithFrame:liveSwipeViewFrame]);

Think these should both mention swipe.

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:79
>  #endif

Why some lowercase?
Comment 3 Simon Fraser (smfr) 2017-02-08 21:21:55 PST 
(In reply to comment #2)
> Comment on attachment 301012 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301012&action=review
> 
> > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:211
> >      m_liveSwipeViewClippingView = adoptNS([[UIView alloc] initWithFrame:liveSwipeViewFrame]);
> 
> Think these should both mention swipe.

Will fix.

> > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:79
> >  #endif
> 
> Why some lowercase?

Because that was convention for WebCore things; I chose lowercase for things we make from GraphicsLayers, and InterCaps for UIView things.
Comment 4 Simon Fraser (smfr) 2017-02-08 21:25:09 PST 
https://trac.webkit.org/r211929