Bug 168021 – Web Inspector: Prefer Resources tab over Network tab when showing files

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

I often find it very annoying that if I open a page after it loads (the Network tab will therefore be empty), it will show a resource (such as via an option-click or context menu) in the Network tab if it was more recently used than the Resources tab.  I think that the Resources tab should always be preferred over the Network tab, unless the Resources tab is not open in the tab bar.

[Devin Rousso]

Created attachment 300975 [details]
Patch

[Devin Rousso]

Comment on attachment 300975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300975&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:118
> +            if (options.ignoreNetworkTab && tabContentView instanceof WebInspector.NetworkTabContentView)

One edge-case I was thinking of would be a situation where no other tab other than the Network tab was currently open and the user clicks a "Reveal in Resources Tab" context menu item.  In this case, a Resources tab is forcibly opened and selected.  I was thinking that "ignoreNetworkTab" (and all other "ignore*Tab" options) would really only act like a suggestion, and if there was no other tab than the Network tab it would still display.  This would be easy to implement, as all you'd have to do is add another loop over `this._recentTabContentViews` but without any `continue`s.  Any thoughts?

[Devin Rousso]

*** Bug 154034 has been marked as a duplicate of this bug. ***

[Timothy Hatcher]

Comment on attachment 300975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300975&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:121
>              if (tabContentView.canShowRepresentedObject(representedObject))

Having NetworkTaContentView override canShowRepresentedObject to return false when the resource isn't in the DataGrid would be good too.

[Devin Rousso]

Created attachment 302305 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302305 [details]
Patch

Clearing flags on attachment: 302305

Committed r212761: <http://trac.webkit.org/changeset/212761>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.