WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168016
[MediaStream] Remove legacy Navigator.webkitGetUserMedia
https://bugs.webkit.org/show_bug.cgi?id=168016
Summary
[MediaStream] Remove legacy Navigator.webkitGetUserMedia
Eric Carlson
Reported
2017-02-08 12:24:32 PST
Remove legacy Navigator.webkitGetUserMedia
Attachments
Proposed patch.
(30.53 KB, patch)
2017-02-08 12:45 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Updated patch.
(35.76 KB, patch)
2017-02-08 13:08 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Updated patch.
(35.76 KB, patch)
2017-02-08 14:02 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Another patch.
(36.63 KB, patch)
2017-02-08 14:32 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Another patch.
(36.95 KB, patch)
2017-02-08 16:54 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
One more time
(42.71 KB, patch)
2017-02-09 07:47 PST
,
Eric Carlson
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Another patch.
(42.71 KB, patch)
2017-02-09 08:53 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2017-02-08 12:45:30 PST
Created
attachment 300937
[details]
Proposed patch.
Eric Carlson
Comment 2
2017-02-08 13:08:46 PST
Created
attachment 300945
[details]
Updated patch.
Eric Carlson
Comment 3
2017-02-08 14:02:26 PST
Created
attachment 300957
[details]
Updated patch.
Eric Carlson
Comment 4
2017-02-08 14:32:04 PST
Created
attachment 300967
[details]
Another patch.
Eric Carlson
Comment 5
2017-02-08 15:26:16 PST
Comment on
attachment 300967
[details]
Another patch. The Mac build failures seem to happen when JSNavigator.cpp isn't regenerated when it should be.
WebKit Commit Bot
Comment 6
2017-02-08 15:52:37 PST
Comment on
attachment 300967
[details]
Another patch. Clearing flags on attachment: 300967 Committed
r211907
: <
http://trac.webkit.org/changeset/211907
>
WebKit Commit Bot
Comment 7
2017-02-08 15:52:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2017-02-08 15:58:44 PST
<
rdar://problem/30431544
>
Chris Dumez
Comment 9
2017-02-08 16:28:02 PST
Reverted
r211907
for reason: Broke the build Committed
r211909
: <
http://trac.webkit.org/changeset/211909
>
Chris Dumez
Comment 10
2017-02-08 16:44:16 PST
(In reply to
comment #5
)
> Comment on
attachment 300967
[details]
> Another patch. > > The Mac build failures seem to happen when JSNavigator.cpp isn't regenerated > when it should be.
I would suggest "touching" Navigator.idl in this patch.
Eric Carlson
Comment 11
2017-02-08 16:54:11 PST
Created
attachment 300984
[details]
Another patch. Touch Navigator.idl to force a rebuild.
WebKit Commit Bot
Comment 12
2017-02-08 17:32:29 PST
Comment on
attachment 300984
[details]
Another patch. Clearing flags on attachment: 300984 Committed
r211912
: <
http://trac.webkit.org/changeset/211912
>
WebKit Commit Bot
Comment 13
2017-02-08 17:32:35 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 14
2017-02-08 20:29:04 PST
Is this caused by this change?
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r211926%20(3412)/http/tests/media/media-stream/disconnected-frame-permission-denied-pretty-diff.html
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r211926%20(3412)/http/tests/media/media-stream/disconnected-frame-pretty-diff.html
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r211926%20(3412)/http/tests/media/media-stream/disconnected-frame-already-pretty-diff.html
youenn fablet
Comment 15
2017-02-08 20:30:17 PST
I would think so
Chris Dumez
Comment 16
2017-02-08 20:40:36 PST
(In reply to
comment #15
)
> I would think so
please fix or roll out.
WebKit Commit Bot
Comment 17
2017-02-08 20:47:30 PST
Re-opened since this is blocked by
bug 168034
youenn fablet
Comment 18
2017-02-08 20:47:47 PST
(In reply to
comment #16
)
> (In reply to
comment #15
) > > I would think so > > please fix or roll out.
OK, let's roll out for now and reland it tomorrow
Eric Carlson
Comment 19
2017-02-09 07:47:40 PST
Created
attachment 301036
[details]
One more time
WebKit Commit Bot
Comment 20
2017-02-09 08:31:55 PST
Comment on
attachment 301036
[details]
One more time Rejecting
attachment 301036
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 301036, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output:
http://webkit-queues.webkit.org/results/3048520
Eric Carlson
Comment 21
2017-02-09 08:53:50 PST
Created
attachment 301044
[details]
Another patch.
WebKit Commit Bot
Comment 22
2017-02-09 09:31:32 PST
Comment on
attachment 301044
[details]
Another patch. Clearing flags on attachment: 301044 Committed
r211962
: <
http://trac.webkit.org/changeset/211962
>
WebKit Commit Bot
Comment 23
2017-02-09 09:31:38 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug