Bug 168012 - Promote WKWebView.allowsRemoteInspection from SPI to API
Summary: Promote WKWebView.allowsRemoteInspection from SPI to API
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Blaze Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-08 11:55 PST by Blaze Burg
Modified: 2020-06-23 13:28 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.04 KB, patch)
2017-02-16 16:42 PST, Blaze Burg 		no flags Details | Formatted Diff | Diff
Patch v2 (3.03 KB, patch)
2017-02-17 13:53 PST, Blaze Burg 		mjs: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Blaze Burg 2017-02-08 11:55:12 PST 
<rdar://problem/29764488>
Comment 1 Blaze Burg 2017-02-16 16:42:35 PST 
Created attachment 301854 [details]
Patch
Comment 2 Geoffrey Garen 2017-02-16 18:29:28 PST 
Did we submit this to API review?
Comment 3 Blaze Burg 2017-02-16 18:32:59 PST 
(In reply to comment #2)
> Did we submit this to API review?

No. Should we? I was under the impression to check it in first.
Comment 4 Geoffrey Garen 2017-02-16 18:39:27 PST 
Yeah, I think we should submit for review and then check in.
Comment 5 Joseph Pecoraro 2017-02-16 19:39:55 PST 
Comment on attachment 301854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301854&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:240
> +@property

This doesn't match the format of other comments. The @property can be dropped and the @abstract on the same line as the /*!
Comment 6 Blaze Burg 2017-02-17 13:53:18 PST 
Created attachment 301983 [details]
Patch v2
Comment 7 Maciej Stachowiak 2020-05-30 18:06:13 PDT 
Comment on attachment 301983 [details]
Patch v2

This seems like a good idea, and I'm surprised this is still SPI, but r- because the patch no longer applies.