NEW 168012
Promote WKWebView.allowsRemoteInspection from SPI to API 
https://bugs.webkit.org/show_bug.cgi?id=168012
Summary Promote WKWebView.allowsRemoteInspection from SPI to API
Blaze Burg
Reported 2017-02-08 11:55:12 PST
<rdar://problem/29764488>
Attachments
Patch (3.04 KB, patch)
2017-02-16 16:42 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v2 (3.03 KB, patch)
2017-02-17 13:53 PST, Blaze Burg 		mjs: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-02-16 16:42:35 PST
Created attachment 301854 [details] Patch
Geoffrey Garen
Comment 2 2017-02-16 18:29:28 PST
Did we submit this to API review?
Blaze Burg
Comment 3 2017-02-16 18:32:59 PST
(In reply to comment #2) > Did we submit this to API review? No. Should we? I was under the impression to check it in first.
Geoffrey Garen
Comment 4 2017-02-16 18:39:27 PST
Yeah, I think we should submit for review and then check in.
Joseph Pecoraro
Comment 5 2017-02-16 19:39:55 PST
Comment on attachment 301854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301854&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:240 > +@property This doesn't match the format of other comments. The @property can be dropped and the @abstract on the same line as the /*!
Blaze Burg
Comment 6 2017-02-17 13:53:18 PST
Created attachment 301983 [details] Patch v2
Maciej Stachowiak
Comment 7 2020-05-30 18:06:13 PDT
Comment on attachment 301983 [details] Patch v2 This seems like a good idea, and I'm surprised this is still SPI, but r- because the patch no longer applies.
Note You need to log in before you can comment on or make changes to this bug.