Bug 168000 - Simple line layout: Fix printReason for unsupported overflow values.
Summary: Simple line layout: Fix printReason for unsupported overflow values.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 09:47 PST by zalan
Modified: 2017-02-08 10:35 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2017-02-08 09:49 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.72 KB, patch)
2017-02-08 09:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-02-08 09:47:58 PST 
It says we don't support overflow visible, but we do.
Comment 1 zalan 2017-02-08 09:49:52 PST 
Created attachment 300914 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-02-08 09:51:41 PST 
Comment on attachment 300914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300914&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:79
> +    FlowHasNoOverflowVisible              = 1LLU  << 13,

Maybe call this FlowHasOverflowNotVisible ?
Comment 3 zalan 2017-02-08 09:57:45 PST 
Created attachment 300915 [details]
Patch
Comment 4 WebKit Commit Bot 2017-02-08 10:35:19 PST 
Comment on attachment 300915 [details]
Patch

Clearing flags on attachment: 300915

Committed r211884: <http://trac.webkit.org/changeset/211884>
Comment 5 WebKit Commit Bot 2017-02-08 10:35:23 PST 
All reviewed patches have been landed.  Closing bug.