RTCPeerConnection constructor can take null as input
Created attachment 300899 [details] Patch
Comment on attachment 300899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300899&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.js:37 > + if (configuration === @undefined || configuration === null) Could you remove this check (and the isObject check, and just make initializeWith take an optional RTCConfiguration?
Comment on attachment 300899 [details] Patch Attachment 300899 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3025623 New failing tests: imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html imported/w3c/web-platform-tests/webrtc/no-media-call.html imported/w3c/web-platform-tests/webrtc/promises-call.html
Created attachment 300909 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 300899 [details] Patch Attachment 300899 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3025616 New failing tests: imported/w3c/web-platform-tests/webrtc/datachannel-emptystring.html imported/w3c/web-platform-tests/webrtc/no-media-call.html imported/w3c/web-platform-tests/webrtc/promises-call.html
Created attachment 300910 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 300911 [details] Patch
Comment on attachment 300911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300911&action=review r=me with comments. > Source/WebCore/ChangeLog:8 > + Covered by updated test. Let's point to the following specs in the Changelog: - https://heycam.github.io/webidl/#es-dictionary - https://www.w3.org/TR/webrtc/#interface-definition > Source/WebCore/Modules/mediastream/RTCPeerConnection.js:37 > + if (configuration === @undefined || configuration === null) Do we want to do configuration == null instead? > LayoutTests/fast/mediastream/RTCPeerConnection.html:10 > + shouldNotThrow("new RTCPeerConnection(null);"); Would be good to test that we end up using the default members values as well.
Comment on attachment 300911 [details] Patch Please see my comments.
> > Source/WebCore/ChangeLog:8 > > + Covered by updated test. > > Let's point to the following specs in the Changelog: > - https://heycam.github.io/webidl/#es-dictionary > - https://www.w3.org/TR/webrtc/#interface-definition OK > > Source/WebCore/Modules/mediastream/RTCPeerConnection.js:37 > > + if (configuration === @undefined || configuration === null) > > Do we want to do configuration == null instead? Sure, this is equivalent. > > LayoutTests/fast/mediastream/RTCPeerConnection.html:10 > > + shouldNotThrow("new RTCPeerConnection(null);"); > > Would be good to test that we end up using the default members values as > well. Right, let's do that in a follow-up patch.
(In reply to comment #2) > Comment on attachment 300899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300899&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.js:37 > > + if (configuration === @undefined || configuration === null) > > Could you remove this check (and the isObject check, and just make > initializeWith take an optional RTCConfiguration? We would need the binding generator to do the argument checking. Currently, that handling is left to the JS built-in code.
Created attachment 300922 [details] Patch for landing
Comment on attachment 300922 [details] Patch for landing Clearing flags on attachment: 300922 Committed r211886: <http://trac.webkit.org/changeset/211886>
All reviewed patches have been landed. Closing bug.