Bug 167989 - Move WKMouseInRect to WAKView.mm
Summary: Move WKMouseInRect to WAKView.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 08:02 PST by Aakash Jain
Modified: 2017-02-08 09:27 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (2.57 KB, patch)
2017-02-08 08:15 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-08 08:02:21 PST 
WKMouseInRect() is only used in WAKView.mm. Having it in a private header (WAKAppKitStubs.h) exposes it more than it should be. We should move it to WAKView.mm
Comment 1 Aakash Jain 2017-02-08 08:15:15 PST 
Created attachment 300898 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2017-02-08 09:09:54 PST 
Comment on attachment 300898 [details]
Proposed patch

I'm not sure abut the original purpose of "WAKAppKitStubs.m", but from what I can tell, this change is correct.
Comment 3 WebKit Commit Bot 2017-02-08 09:27:55 PST 
Comment on attachment 300898 [details]
Proposed patch

Clearing flags on attachment: 300898

Committed r211878: <http://trac.webkit.org/changeset/211878>
Comment 4 WebKit Commit Bot 2017-02-08 09:27:59 PST 
All reviewed patches have been landed.  Closing bug.