WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167989
Move WKMouseInRect to WAKView.mm
https://bugs.webkit.org/show_bug.cgi?id=167989
Summary
Move WKMouseInRect to WAKView.mm
Aakash Jain
Reported
2017-02-08 08:02:21 PST
WKMouseInRect() is only used in WAKView.mm. Having it in a private header (WAKAppKitStubs.h) exposes it more than it should be. We should move it to WAKView.mm
Attachments
Proposed patch
(2.57 KB, patch)
2017-02-08 08:15 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2017-02-08 08:15:15 PST
Created
attachment 300898
[details]
Proposed patch
Alexey Proskuryakov
Comment 2
2017-02-08 09:09:54 PST
Comment on
attachment 300898
[details]
Proposed patch I'm not sure abut the original purpose of "WAKAppKitStubs.m", but from what I can tell, this change is correct.
WebKit Commit Bot
Comment 3
2017-02-08 09:27:55 PST
Comment on
attachment 300898
[details]
Proposed patch Clearing flags on attachment: 300898 Committed
r211878
: <
http://trac.webkit.org/changeset/211878
>
WebKit Commit Bot
Comment 4
2017-02-08 09:27:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug