Bug 167985 - [GTK] Test fast/forms/select-empty-option-height.html fails
Summary: [GTK] Test fast/forms/select-empty-option-height.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-02-08 06:43 PST by Carlos Garcia Campos
Modified: 2017-02-08 08:27 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2017-02-08 06:45 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-08 06:43:04 PST 
This seems to be a problem with the differences in scroll step or the size of the items in the list. The thing is that 10 attempts with an scroll amount of 10 is not enoug in the GTk+ port to scroll the list to the desired point. Either increasing the scroll amount or the maximum attempts would fix the test. Increasing the scroll amount would break the test in other ports so better use a higher number of maximum attempts.
Comment 1 Carlos Garcia Campos 2017-02-08 06:45:44 PST 
Created attachment 300893 [details]
Patch
Comment 2 Michael Catanzaro 2017-02-08 07:50:21 PST 
Comment on attachment 300893 [details]
Patch

We expect our list items to use theme size and not match other ports, I presume?
Comment 3 Carlos Garcia Campos 2017-02-08 08:27:24 PST 
Committed r211872: <http://trac.webkit.org/changeset/211872>