Bug 167980 - [GTK] Reduce TiledBackingStore tile coverage when on memory pressure state
Summary: [GTK] Reduce TiledBackingStore tile coverage when on memory pressure state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 02:32 PST by Miguel Gomez
Modified: 2017-02-08 04:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.03 KB, patch)
2017-02-08 02:39 PST, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2017-02-08 03:09 PST, Miguel Gomez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2017-02-08 02:32:42 PST 
Currently we use a hardcoded coverAreaMultiplier value of 2 in the TiledBackingStore, which means that the area we fill with tiles has up to 2 times the size of the visible area. While this is nice to make scrolling smoother, we are using more memory than needed to render the visible contents of layers (1 extra MB per tile).
When we are in memory pressure situation, we can reduce that value to use less tiles and improve the memory consumption.
Comment 1 Miguel Gomez 2017-02-08 02:39:10 PST 
Created attachment 300885 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-08 02:44:20 PST 
Comment on attachment 300885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300885&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:148
> +void TiledBackingStore::createTiles(const IntRect& visibleRect, const IntRect& scaledContentsRect, const float coverAreaMultiplier)

I don't think that const is needed for a float parameter passed by value, no?
Comment 3 Miguel Gomez 2017-02-08 03:09:04 PST 
Created attachment 300887 [details]
Patch
Comment 4 WebKit Commit Bot 2017-02-08 04:20:37 PST 
Comment on attachment 300887 [details]
Patch

Clearing flags on attachment: 300887

Committed r211867: <http://trac.webkit.org/changeset/211867>
Comment 5 WebKit Commit Bot 2017-02-08 04:20:42 PST 
All reviewed patches have been landed.  Closing bug.