Bug 167979 – Implement URL's toJSON()

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

Tests: https://github.com/w3c/web-platform-tests/pull/4702.

Standard: https://url.spec.whatwg.org/#dom-url-tojson.

[Chris Dumez]

Created attachment 301204 [details]
WIP Patch

[Alex Christensen]

I think we should add a test like "https://example.com/#\"" to verify what happens when a " appears in the serialized URL.

[Chris Dumez]

(In reply to comment #2)
> I think we should add a test like "https://example.com/#\"" to verify what
> happens when a " appears in the serialized URL.

In Firefox nightly:
JSON.stringify(new URL("https://example.com/#\""))  
 "https://example.com/#%22"

With my patch:
JSON.stringify(new URL("https://example.com/#\""))
 "\"https://example.com/#\\\"\""

[Chris Dumez]

(In reply to comment #3)
> (In reply to comment #2)
> > I think we should add a test like "https://example.com/#\"" to verify what
> > happens when a " appears in the serialized URL.
> 
> In Firefox nightly:
> JSON.stringify(new URL("https://example.com/#\""))  
>  "https://example.com/#%22"
> 
> With my patch:
> JSON.stringify(new URL("https://example.com/#\""))
>  "\"https://example.com/#\\\"\""

Alex, any thoughts on this? Not super familiar with this so I am not sure what's expected. The URL serialization merely says to append the fragment.

Either way, this would be an issue with our serialization and would also impact the stringier, not only the new toJSON.

[Chris Dumez]

Created attachment 301240 [details]
Patch

[Anne van Kesteren]

Chris, the difference you are seeing is because Firefox encodes more code points during parsing of the URL fragment. Firefox is the only browser to do so, so I think the results of your patch are indeed what you should be seeing here. See https://url.spec.whatwg.org/#fragment-state in particular.

[Chris Dumez]

(In reply to comment #6)
> Chris, the difference you are seeing is because Firefox encodes more code
> points during parsing of the URL fragment. Firefox is the only browser to do
> so, so I think the results of your patch are indeed what you should be
> seeing here. See https://url.spec.whatwg.org/#fragment-state in particular.

Thanks for confirming.

[WebKit Commit Bot]

Comment on attachment 301240 [details]
Patch

Clearing flags on attachment: 301240

Committed r212193: <http://trac.webkit.org/changeset/212193>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.