Bug 167942 – Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

<rdar://problem/30315079>

[Wenson Hsieh]

Created attachment 300815 [details]
Patch

[Sam Weinig]

Comment on attachment 300815 [details]
Patch

Is this really only needed under ENABLE(DATA_INTERACTION)?

[Wenson Hsieh]

(In reply to comment #2)
> Comment on attachment 300815 [details]
> Patch
> 
> Is this really only needed under ENABLE(DATA_INTERACTION)?

I believe so. In Pasteboard::read (in PasteboardMac.mm) we don't seem to support reading these types.

[Sam Weinig]

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 300815 [details]
> > Patch
> > 
> > Is this really only needed under ENABLE(DATA_INTERACTION)?
> 
> I believe so. In Pasteboard::read (in PasteboardMac.mm) we don't seem to
> support reading these types.

Should we? Is there a good reason to support different types?

[Wenson Hsieh]

Created attachment 300881 [details]
Patch

[Wenson Hsieh]

I have progress on test cases in TestWebKitAPI that use an NSView that vends only a certain UTI type (in this case, UTF8 or JPEG) when dragging. The test attempts to drag from this NSView into a web view and observe the inserted contents, but sending mouse dragged events isn't resulting in any dragging taking place for some reason. Into AppKit to find out why...

[Wenson Hsieh]

Created attachment 300949 [details]
Patch

[Wenson Hsieh]

Created attachment 300951 [details]
Build fix

[Wenson Hsieh]

Created attachment 300958 [details]
Move ivars to interface declaration.

[Tim Horton]

Comment on attachment 300958 [details]
Move ivars to interface declaration.

View in context: https://bugs.webkit.org/attachment.cgi?id=300958&action=review

> Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:36
> +    dispatch_block_t _completionBlock;

No BlockPtr love?

> Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:223
> +    [hostWindow setFrameOrigin:NSMakePoint(0, 0)];

Is this on-screen? We probably don't want that. Does it have to be?

[Wenson Hsieh]

Created attachment 300970 [details]
Patch for landing

[Wenson Hsieh]

(In reply to comment #10)
> Comment on attachment 300958 [details]
> Move ivars to interface declaration.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300958&action=review
> 
> > Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:36
> > +    dispatch_block_t _completionBlock;
> 
> No BlockPtr love?

Changed to use BlockPtr :)

> 
> > Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:223
> > +    [hostWindow setFrameOrigin:NSMakePoint(0, 0)];
> 
> Is this on-screen? We probably don't want that. Does it have to be?

Good point -- removed setVisible: and makeKeyAndOrderFront: -- it no longer appears on screen.

Thanks!

[WebKit Commit Bot]

Comment on attachment 300970 [details]
Patch for landing

Clearing flags on attachment: 300970

Committed r211906: <http://trac.webkit.org/changeset/211906>