Ports are set to zero for UDP and server TCP
Created attachment 300812 [details] Patch
Attachment 300812 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/webrtc/LibWebRTCSocketClient.h:52: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 300812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300812&action=review > LayoutTests/webrtc/no-port-zero-in-upd-candidates.html:35 > + pc.createOffer().then((offer) => { This is a great place to start using async / await!
Created attachment 300828 [details] Patch for landing
(In reply to comment #3) > Comment on attachment 300812 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300812&action=review > > > LayoutTests/webrtc/no-port-zero-in-upd-candidates.html:35 > > + pc.createOffer().then((offer) => { > > This is a great place to start using async / await! Not sure how this improves things here. I did some refactoring though to isolate grabbing of all ICE candidates.
Comment on attachment 300828 [details] Patch for landing Clearing flags on attachment: 300828 Committed r211830: <http://trac.webkit.org/changeset/211830>
All reviewed patches have been landed. Closing bug.