RESOLVED FIXED Bug 167935
[Modern Media Controls] Remove placard icon if height is compressed 
https://bugs.webkit.org/show_bug.cgi?id=167935
Summary [Modern Media Controls] Remove placard icon if height is compressed
Antoine Quint
Reported 2017-02-07 07:21:26 PST
We should hide the placard's icon should the height become cramped (170pt or below).
Attachments
Patch (25.91 KB, patch)
2017-03-24 13:08 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-07 07:22:13 PST
<rdar://problem/30397128>
Antoine Quint
Comment 2 2017-03-24 13:08:00 PDT
Created attachment 305315 [details] Patch
Dean Jackson
Comment 3 2017-03-24 14:39:53 PDT
Comment on attachment 305315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305315&action=review > LayoutTests/media/modern-media-controls/layout-node/node-made-dirty-during-commit.html:25 > +const node = new CustomNode; > +node.x = 20; See! This is why JS const is crap.
WebKit Commit Bot
Comment 4 2017-03-24 16:32:17 PDT
Comment on attachment 305315 [details] Patch Clearing flags on attachment: 305315 Committed r214386: <http://trac.webkit.org/changeset/214386>
WebKit Commit Bot
Comment 5 2017-03-24 16:32:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.