Bug 167933 - [Modern Media Controls] Implement reduced and tight padding modes
Summary: [Modern Media Controls] Implement reduced and tight padding modes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-07 07:07 PST by Antoine Quint
Modified: 2017-02-08 14:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (69.78 KB, patch)
2017-02-08 12:53 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (883.49 KB, application/zip)
2017-02-08 14:09 PST, Build Bot
no flags Details
Patch for landing (69.70 KB, patch)
2017-02-08 14:20 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-07 07:07:58 PST
The modern media controls, on top of allowing for a compact/legacy mode, also have "reduced" and "tight" padding modes:

- in the scrubber's absence, inline video controls at or below 300pt width use a 12pt left margin for the left buttons container, and a 12pt right margin for the right buttons container, and 16pth button margin inside both containers

- when dropping at or below 120pt width, inline video controls use an 8pt left margin for the left buttons container, and an 8pt right margin for the right buttons container, and 12pt button margin inside both containers

- in the case of audio controls, at 400pt or less, inline controls switch to 12pt margins and button margins for both buttons containers
Comment 1 Radar WebKit Bug Importer 2017-02-07 07:08:27 PST
<rdar://problem/30396994>
Comment 2 Antoine Quint 2017-02-07 07:31:12 PST
Actually, the 120pt or below case is already covered by the compact controls.
Comment 3 Antoine Quint 2017-02-08 12:53:14 PST
Created attachment 300940 [details]
Patch
Comment 4 Build Bot 2017-02-08 14:09:46 PST
Comment on attachment 300940 [details]
Patch

Attachment 300940 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3027138

New failing tests:
media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html
Comment 5 Build Bot 2017-02-08 14:09:48 PST
Created attachment 300959 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Antoine Quint 2017-02-08 14:20:40 PST
Created attachment 300965 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-02-08 14:59:11 PST
Comment on attachment 300965 [details]
Patch for landing

Clearing flags on attachment: 300965

Committed r211904: <http://trac.webkit.org/changeset/211904>
Comment 8 WebKit Commit Bot 2017-02-08 14:59:15 PST
All reviewed patches have been landed.  Closing bug.