Bug 167933 – [Modern Media Controls] Implement reduced and tight padding modes

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

The modern media controls, on top of allowing for a compact/legacy mode, also have "reduced" and "tight" padding modes:

- in the scrubber's absence, inline video controls at or below 300pt width use a 12pt left margin for the left buttons container, and a 12pt right margin for the right buttons container, and 16pth button margin inside both containers

- when dropping at or below 120pt width, inline video controls use an 8pt left margin for the left buttons container, and an 8pt right margin for the right buttons container, and 12pt button margin inside both containers

- in the case of audio controls, at 400pt or less, inline controls switch to 12pt margins and button margins for both buttons containers

[Radar WebKit Bug Importer]

<rdar://problem/30396994>

[Antoine Quint]

Actually, the 120pt or below case is already covered by the compact controls.

[Antoine Quint]

Created attachment 300940 [details]
Patch

[Build Bot]

Comment on attachment 300940 [details]
Patch

Attachment 300940 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3027138

New failing tests:
media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html

[Build Bot]

Created attachment 300959 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 300965 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 300965 [details]
Patch for landing

Clearing flags on attachment: 300965

Committed r211904: <http://trac.webkit.org/changeset/211904>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.