Bug 167931 – [GTK][Efl] Do not require LibXslt if XSLT is disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Olivier Blin]

Build with --no-xslt fails when the libxslt dev files are not installed, while they are not needed.

[Olivier Blin]

Created attachment 300807 [details]
Patch

[Olivier Blin]

As a side note, this has been noticed on WebKitForWayland first, it would be nice to factorize options that are common to non-Apple ports (GTK, Efl, WPE, Qt).

[Michael Catanzaro]

Comment on attachment 300807 [details]
Patch

I don't think we should support building with ENABLE_XSLT=OFF. Why do you want to do this?

[Konstantin Tokarev]

FWIW, I do this to avoid extra dependency and reduce WebKit size a bit for embedded system, XSLT is not a very popular Web feature

[Olivier Blin]

Because I don't need libxslt and the XSL stylesheets feature in my embedded systems (set-top boxes).

[Michael Catanzaro]

Comment on attachment 300807 [details]
Patch

*grumble not supported grumble*

[Adrian Perez]

It makes sense to be able to disable seldom used features (like XSLT)
at build time, when targeting embedded hardware with limited resources.
This is something that it's interesting to support.

XSLT should be enabled and built by default, though. As long as the
proposed patch keeps XSLT enabled unless explicitly disabled, it looks
good to me.

[WebKit Commit Bot]

Comment on attachment 300807 [details]
Patch

Clearing flags on attachment: 300807

Committed r211813: <http://trac.webkit.org/changeset/211813>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.