RESOLVED FIXED 167913
[MediaStream Mac] Remove some unused code 
https://bugs.webkit.org/show_bug.cgi?id=167913
Summary [MediaStream Mac] Remove some unused code
Eric Carlson
Reported 2017-02-06 17:11:15 PST
Minor CaptureDeviceManager cleanup.
Attachments
Proposed patch. (7.46 KB, patch)
2017-02-06 17:16 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-02-06 17:16:24 PST
Created attachment 300772 [details] Proposed patch.
Jer Noble
Comment 2 2017-02-06 17:17:41 PST
Comment on attachment 300772 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=300772&action=review > Source/WebCore/platform/mediastream/CaptureDeviceManager.h:41 > - bool m_enabled { false }; > + String m_groupID { emptyString() }; > + bool m_enabled { true }; This change isn't functional?
Jer Noble
Comment 3 2017-02-06 17:18:57 PST
Comment on attachment 300772 [details] Proposed patch. Over IRC, eric answered my question above (it's always set to true later).
Radar WebKit Bug Importer
Comment 4 2017-02-06 17:20:30 PST
<rdar://problem/30388368>
WebKit Commit Bot
Comment 5 2017-02-06 17:35:12 PST
Comment on attachment 300772 [details] Proposed patch. Clearing flags on attachment: 300772 Committed r211761: <http://trac.webkit.org/changeset/211761>
WebKit Commit Bot
Comment 6 2017-02-06 17:35:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.