Bug 167912 - ExtendedColor leaks seen on leaks bot
Summary: ExtendedColor leaks seen on leaks bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 16:38 PST by Joseph Pecoraro
Modified: 2017-02-06 18:41 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.25 KB, patch)
2017-02-06 16:43 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-02-06 16:38:51 PST 
ExtendedColor leaks seen on leaks bot

Test:
WebCore::Color c1(1.0, 0.5, 0.25, 1.0, WebCore::ColorSpaceDisplayP3);
WebCore::Color c2(0.1, 0.5, 0.25, 1.0, WebCore::ColorSpaceDisplayP3);
c1 = WTFMove(c2);

Leak:
Leak: 0x7fdda21060f0  size=32  zone: WebKit Using System Malloc_0x10f14c000
	0x00000001 0x60000000 0x3f800000 0x3f000000 	.......`...?...?
	0x3e800000 0x3f800000 0x00000003 0x706d6f63 	...>...?....comp
	Call stack: [thread 0x7fffc18523c0]: 
        | 0x1 
        | start 
        ...
        | WebKit::testLeak()
        | WebCore::Color::Color(float, float, float, float, WebCore::ColorSpace) Color.cpp:308 
        | WebCore::Color::Color(float, float, float, float, WebCore::ColorSpace) Color.cpp:305 
        | WebCore::ExtendedColor::create(float, float, float, float, WebCore::ColorSpace) ExtendedColor.cpp:38 
        | WTF::RefCounted<WebCore::ExtendedColor>::operator new(unsigned long) RefCounted.h:140 
        | WTF::fastMalloc(unsigned long) FastMalloc.cpp:256 
        | bmalloc::api::malloc(unsigned long) bmalloc.h:43 
        | bmalloc::Cache::allocate(unsigned long) Cache.h:80 
        | bmalloc::Allocator::allocate(unsigned long) Allocator.h:89 
        | bmalloc::Allocator::allocateSlowCase(unsigned long) Allocator.cpp:187 
        | bmalloc::DebugHeap::malloc(unsigned long) DebugHeap.cpp:44
Comment 1 Joseph Pecoraro 2017-02-06 16:43:31 PST 
Created attachment 300767 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2017-02-06 18:41:31 PST 
Comment on attachment 300767 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 300767

Committed r211768: <http://trac.webkit.org/changeset/211768>
Comment 3 WebKit Commit Bot 2017-02-06 18:41:35 PST 
All reviewed patches have been landed.  Closing bug.