Bug 167906 - svn-create-patch duplicating deletes
Summary: svn-create-patch duplicating deletes
Status: RESOLVED DUPLICATE of bug 14590
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 14:48 PST by Jonathan Bedard
Modified: 2018-09-03 11:10 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-02-06 14:48:25 PST
svn-create-patch will duplicate deletes, https://bugs.webkit.org/attachment.cgi?id=300680 is a good example of this.  Among other files, PerformanceTests/ES6SampleBench/Basic/util.js is deleted 3 times.
Comment 1 Jonathan Bedard 2017-02-06 16:29:10 PST
I was able to reproduce this.

This is a bug in svn-create-patch.  If you delete a file and then move the directory the file that was deleted is in, the resulting patch will have duplicated the delete.  The commands to reproduce this are:

rm SomeDir/file.txt
svn rm SomeDir/file.txt
svn mv SomeDir SomeNewDir

I would guess that this was caused by https://bugs.webkit.org/show_bug.cgi?id=167169.
Comment 2 Alexey Proskuryakov 2017-02-06 17:07:21 PST
Is this a duplicate of bug 167903?
Comment 3 Jonathan Bedard 2017-02-07 08:07:36 PST
*** Bug 167903 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Bedard 2017-02-07 08:08:36 PST
(In reply to comment #2)
> Is this a duplicate of bug 167903?

Yes, it is the same issue.  Marked the other as a duplicate since this one has more than just a report.
Comment 5 Alexey Proskuryakov 2017-02-07 09:05:01 PST

*** This bug has been marked as a duplicate of bug 167903 ***
Comment 6 Alexey Proskuryakov 2017-02-07 09:36:59 PST
Jonathan and I look into this briefly, and this may end up being a separate bug - there are no deletes in bug 167903.
Comment 7 Jonathan Bedard 2017-02-07 10:14:26 PST
This is not a duplicate of bug 167903, they are different issues.
Comment 8 David Kilzer (:ddkilzer) 2018-09-03 11:10:19 PDT
This is a duplicate of:

Bug 14590: svn-create-patch fails when svn mv is used on directory trees

The patch I have to fix that (not v1) also fixes this issue.

*** This bug has been marked as a duplicate of bug 14590 ***