Bug 167896 - [EME] Alias CDMInstance enums to the specification-defined enums
Summary: [EME] Alias CDMInstance enums to the specification-defined enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 11:40 PST by Zan Dobersek
Modified: 2017-02-08 01:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.70 KB, patch)
2017-02-06 11:44 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (9.45 KB, patch)
2017-02-07 06:53 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-02-06 11:40:00 PST 
[EME] Utility functions for conversions between CDMInstance and W3C EME enums
Comment 1 Zan Dobersek 2017-02-06 11:44:16 PST 
Created attachment 300743 [details]
Patch
Comment 2 Sam Weinig 2017-02-06 11:59:15 PST 
Comment on attachment 300743 [details]
Patch

Is there a reason to have both types here?  Can we just define one to be the other using a using declaration?
Comment 3 Zan Dobersek 2017-02-07 04:40:08 PST 
(In reply to comment #2)
> Comment on attachment 300743 [details]
> Patch
> 
> Is there a reason to have both types here?  Can we just define one to be the
> other using a using declaration?

That would be the simplest approach. Given that MediaKeySystemConfiguration is already used in CDMInstance, the CDMInstance types could alias to the spec-defined ones. If ever the CDMInstance interface gets pushed into the platform layer, or is used from there, then this would require changing.
Comment 4 Zan Dobersek 2017-02-07 06:53:46 PST 
Created attachment 300808 [details]
Patch
Comment 5 Sam Weinig 2017-02-07 08:47:38 PST 
Comment on attachment 300808 [details]
Patch

Nice.
Comment 6 Zan Dobersek 2017-02-08 01:36:16 PST 
Comment on attachment 300808 [details]
Patch

Clearing flags on attachment: 300808

Committed r211855: <http://trac.webkit.org/changeset/211855>
Comment 7 Zan Dobersek 2017-02-08 01:36:24 PST 
All reviewed patches have been landed.  Closing bug.