Bug 167887 – REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jeremy Bicha]

Originally reported at https://bugzilla.gnome.org/778240 but reporting here now since it may be an unintentional WebKit regression.

Ubuntu GNOME 17.04 Alpha
yelp 3.22.0-1ubuntu1
webkit2gtk 2.15.4-1ubuntu1

yelp is GNOME's help app for viewing user documention.

The embedded videos provided by gnome-getting-started-docs don't work with webkit 2.15.4

More specifically, I see the subtitles and the play menubar with the slider and the timestamp/time remaining but the video content is solid black. And if I let the video play to the end, clicking the X or pressing the Esc key to close the video player does nothing.

And sometimes, the video doesn't play at all (no slider, no subtitles).

I tried rebuilding yelp against webkit 2.15 but that didn't make a difference.

[Carlos Garcia Campos]

This was broken by r210740. When the video sink is created, the media player doesn't have a renderer yet, and accelerated compositing is not available in that moment. When the video starts playing we have Ac available but we cached the value, so we end up mixing the drawing models.

[Carlos Garcia Campos]

Note also that the accelerated compositing setting can change too.

[Carlos Garcia Campos]

Created attachment 300806 [details]
Patch

[Michael Catanzaro]

Comment on attachment 300806 [details]
Patch

Is it not possible to make a layout test for this?

This is exactly the sort of regression I was worried could happen when we decided to backport on-demand accelerated compositing to 2.14. At least we caught it *barely* in time for 2.14.4, but it feels like luck that Jeremy decided to test 2.15.4 at just the right time. I know the status of accelerated compositing in 2.14 is a really exceptional situation and we probably ought to make the change in the stable branch anyway, but we need to avoid large stable branch changes like this in the future, especially so late in the cycle.

[Carlos Garcia Campos]

This is not because of on-demand Ac mode. Even when Ac mode forced, when the media player doesn't have a renderer, the condition will not be tru, because mediaPlayerRenderingCanBeAccelerated will return false.

[Carlos Garcia Campos]

Committed r211854: <http://trac.webkit.org/changeset/211854>

[Jeremy Bicha]

Thanks. I confirm the patch fixes my issue.