RESOLVED FIXED167875
[Modern Media Controls] Bring fullscreen controls up to spec 
https://bugs.webkit.org/show_bug.cgi?id=167875
Summary [Modern Media Controls] Bring fullscreen controls up to spec
Antoine Quint
Reported 2017-02-06 05:31:08 PST
We're missing the volume down and volume up buttons in fullscreen on macOS and the PiP button is too large.
Attachments
Patch (52.14 KB, patch)
2017-02-06 05:41 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews112 for mac-elcapitan (1.72 MB, application/zip)
2017-02-06 06:42 PST, Build Bot 		no flags
Details
Patch for landing (53.49 KB, patch)
2017-02-06 07:40 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-02-06 05:31:22 PST
<rdar://problem/29611222>
Antoine Quint
Comment 2 2017-02-06 05:41:15 PST
Created attachment 300714 [details] Patch
Build Bot
Comment 3 2017-02-06 06:42:14 PST
Comment on attachment 300714 [details] Patch Attachment 300714 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3013540 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html
Build Bot
Comment 4 2017-02-06 06:42:16 PST
Created attachment 300717 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antoine Quint
Comment 5 2017-02-06 07:40:26 PST
Created attachment 300721 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-02-06 08:18:24 PST
Comment on attachment 300721 [details] Patch for landing Clearing flags on attachment: 300721 Committed r211723: <http://trac.webkit.org/changeset/211723>
WebKit Commit Bot
Comment 7 2017-02-06 08:18:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.