Bug 167869 – [EME] Implement MediaKeySession::close()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Zan Dobersek]

SSIA.

[Zan Dobersek]

Created attachment 300693 [details]
Patch

[Jer Noble]

Comment on attachment 300693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300693&action=review

> LayoutTests/media/encrypted-media/mock-MediaKeySession-close.html:57
> +    function stringToUInt8Array(str)
> +    {
> +       var array = new Uint8Array(str.length);
> +       for (var i=0; i<str.length; i++)
> +            array[i] = str.charCodeAt(i);
> +       return array;

So recently Alex Christensen landed support for TextEncoder, which is awesome, since we can now do something like:

    var encoder = new TextEncoder();

    function stringToUint8Array(str) { return encoder.encode(str); }

(or just use encoder.encode(str) everywhere directly.)

I need to go back over all our test cases that use stringToUint8Array() and adapt them to use TextEncoder instead. If you'd like, you could do this before landing, or leave it for me to do later.

[Zan Dobersek]

Comment on attachment 300693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300693&action=review

>> LayoutTests/media/encrypted-media/mock-MediaKeySession-close.html:57
>> +       return array;
> 
> So recently Alex Christensen landed support for TextEncoder, which is awesome, since we can now do something like:
> 
>     var encoder = new TextEncoder();
> 
>     function stringToUint8Array(str) { return encoder.encode(str); }
> 
> (or just use encoder.encode(str) everywhere directly.)
> 
> I need to go back over all our test cases that use stringToUint8Array() and adapt them to use TextEncoder instead. If you'd like, you could do this before landing, or leave it for me to do later.

I can do it before landing. I think using it directly everywhere would work best.

[Zan Dobersek]

Created attachment 300884 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 300884 [details]
Patch for landing

Clearing flags on attachment: 300884

Committed r211856: <http://trac.webkit.org/changeset/211856>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.