Bug 167856 - [JSC] Add fast BytecodeGraph construction mode
Summary: [JSC] Add fast BytecodeGraph construction mode
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 167725
Blocks:
  Show dependency tree / graph
 
Reported: 2017-02-05 11:03 PST by Yusuke Suzuki
Modified: 2017-02-05 12:29 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-02-05 11:03:56 PST 
...
Comment 1 Saam Barati 2017-02-05 11:08:15 PST 
This would be cool. What's your plan here to make it faster?
Comment 2 Yusuke Suzuki 2017-02-05 11:12:47 PST 
(In reply to comment #1)
> This would be cool. What's your plan here to make it faster?

Do not collect BytecodeBasicBlock::m_offsets. Sometimes we do not need this information.
I think this reduces memory allocation if the basic block is super large. Like, kraken's data initialization.
Comment 3 Saam Barati 2017-02-05 12:29:46 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > This would be cool. What's your plan here to make it faster?
> 
> Do not collect BytecodeBasicBlock::m_offsets. Sometimes we do not need this
> information.
> I think this reduces memory allocation if the basic block is super large.
> Like, kraken's data initialization.

Nice! I measured that it took something like 3-5ms to run the algorithm on the huge program code block from ai-astart. So any improvement for this would be awesome.