Bug 167851 - Leaks bot should use WebKit2
Summary: Leaks bot should use WebKit2
Status: RESOLVED DUPLICATE of bug 69543
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-04 23:53 PST by Andreas Kling
Modified: 2018-12-06 13:42 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2017-02-04 23:53:08 PST 
I think we should switch over the leaks bot to using WebKit2. It's super red anyway, and any burndown effort would be better spent on WK2 issues than WK1 ones, in my opinion.
Comment 1 Andreas Kling 2017-02-04 23:56:45 PST 
Actually, I'm really lost in how the bots are set up, so I'm unassigning it from myself.

@Alexey: do you agree that we should do this, and if so, do you think it would be easy?
Comment 2 Alexey Proskuryakov 2017-02-05 08:42:38 PST 
I agree that testing wk2 would be much better. 

Reconfiguring bots is easy, but first, we need to figure out how to do this in principle. A naive approach would result in only seeing UI process leaks.

Unrelated to this, we should switch the bot to Sierra ASAP. It has a fix for a huge networking leak that adds a lot of noise. I'll take care of this.
Comment 3 Andreas Kling 2017-02-05 08:46:35 PST 
Absolutely agreed about Sierra.

A slightly less naive approach could simply run "leaks" on each of our processes (WKTR, WebContent, Networking, Databases) and concatenate the results.

I think it would still be useful, and we'd want to see leaks in all processes anyway.
Comment 4 Alexey Proskuryakov 2018-12-06 13:42:14 PST 

*** This bug has been marked as a duplicate of bug 69543 ***