Bug 167845 – Static Analyzer: Value stored to 'recordedMachineThreads' during its initialization is never read

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

Seeing the following Static Analyzer Warnings:

> AnalyzeShallow heap/MachineStackMarker.cpp
> Source/JavaScriptCore/heap/MachineStackMarker.cpp:151:14: warning: Value stored to 'recordedMachineThreads' during its initialization is never read
>         auto recordedMachineThreads = m_set.take(machineThreads);
>              ^~~~~~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~
> Source/JavaScriptCore/heap/MachineStackMarker.cpp:179:5: warning: Returning null reference
>     return *manager;
>     ^~~~~~~~~~~~~~~
> 2 warnings generated.

The first seems valid given some context:

    auto recordedMachineThreads = m_set.take(machineThreads);
    RELEASE_ASSERT(recordedMachineThreads = machineThreads);

Seems the assert should be an `==` instead of an `=`.

[Joseph Pecoraro]

Created attachment 300647 [details]
[PATCH] Proposed Fix

[Saam Barati]

Comment on attachment 300647 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 300647 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 300647

Committed r211678: <http://trac.webkit.org/changeset/211678>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/30977452>