Bug 167844 – Static Analyzer: Value stored to 'prev' is never read

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

Seeing this static analyzer warning all over JavaScriptCore:

Source/JavaScriptCore/runtime/JSMapIterator.h:60:13: warning: Value stored to 'prev' is never read
            prev = bucket;
            ^      ~~~~~~
Source/JavaScriptCore/runtime/JSSetIterator.h:60:13: warning: Value stored to 'prev' is never read
            prev = bucket;
            ^      ~~~~~~
2 warnings generated.

[Joseph Pecoraro]

Created attachment 300646 [details]
[PATCH] Proposed Fix

[Saam Barati]

Comment on attachment 300646 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=300646&action=review

r=me

> Source/JavaScriptCore/runtime/JSMapIterator.h:59
> +        while (bucket && bucket->deleted())

Oh wow. Can you add a test that would cause this to infinite loop? I don't think it'd be hard. Perhaps something like this:
- add three entries to a map
- get an iterator to give result of the first entry
- delete all entries
- call next

[Radar WebKit Bug Importer]

<rdar://problem/30364994>

[Saam Barati]

Comment on attachment 300646 [details]
[PATCH] Proposed Fix

Ignore my previous comment, I misread the diff, thinking that bucket = bucket->next() was only just now added.

[WebKit Commit Bot]

Comment on attachment 300646 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 300646

Committed r211675: <http://trac.webkit.org/changeset/211675>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.