Bug 167841 - Web Inspector: changing dock side from windowed to bottom should cause split console to collapse on Timeline and Network tabs
Summary: Web Inspector: changing dock side from windowed to bottom should cause split ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-04 15:35 PST by Brian Burg
Modified: 2017-02-09 12:13 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2017-02-09 09:51 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-02-04 15:35:51 PST
Per https://bugs.webkit.org/show_bug.cgi?id=167075, we don't support split console when docked. But if we are showing split console then become docked, the split console is still showing and makes the Timeline tab impossible to read. We should listen for dock side changes and collapse the split console if it isn't supported for the new tab+dock side combination.
Comment 1 Radar WebKit Bug Importer 2017-02-04 15:36:06 PST
<rdar://problem/30364851>
Comment 2 Devin Rousso 2017-02-09 09:51:18 PST
Created attachment 301052 [details]
Patch
Comment 3 WebKit Commit Bot 2017-02-09 12:13:48 PST
Comment on attachment 301052 [details]
Patch

Clearing flags on attachment: 301052

Committed r211976: <http://trac.webkit.org/changeset/211976>
Comment 4 WebKit Commit Bot 2017-02-09 12:13:52 PST
All reviewed patches have been landed.  Closing bug.