Bug 167840 – Simple line layout: Bail out from Simple Line Layout on surrogate pairs.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

We don't yet support them.

[Radar WebKit Bug Importer]

<rdar://problem/30364784>

[alan]

Created attachment 300642 [details]
Patch

[Build Bot]

Comment on attachment 300642 [details]
Patch

Attachment 300642 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3005791

New failing tests:
fast/inline/simple-line-layout-16bit-content.html
fast/text/hyphenate-limit-lines.html
imported/blink/fast/text/international/kana-voiced-sound-marks.html

[Build Bot]

Created attachment 300649 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300642 [details]
Patch

Attachment 300642 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3005746

New failing tests:
fast/inline/simple-line-layout-16bit-content.html
imported/blink/fast/text/international/kana-voiced-sound-marks.html

[Build Bot]

Created attachment 300650 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300642 [details]
Patch

Attachment 300642 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3005796

New failing tests:
fast/inline/simple-line-layout-16bit-content.html
fast/text/hyphenate-limit-lines.html
imported/blink/fast/text/international/kana-voiced-sound-marks.html

[Build Bot]

Created attachment 300651 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[alan]

Created attachment 300657 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 300657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300657&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:186
> +        auto characterReasons = canUseForCharacter(character, textIsJustified, includeReasons);

What's the reason for moving this up?

[WebKit Commit Bot]

Comment on attachment 300657 [details]
Patch

Clearing flags on attachment: 300657

Committed r211680: <http://trac.webkit.org/changeset/211680>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.