Bug 167840 - Simple line layout: Bail out from Simple Line Layout on surrogate pairs.
Summary: Simple line layout: Bail out from Simple Line Layout on surrogate pairs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-04 15:11 PST by zalan
Modified: 2017-02-05 06:42 PST (History)
12 users (show)

See Also:


Attachments
Patch (4.75 KB, patch)
2017-02-04 15:48 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.12 MB, application/zip)
2017-02-04 16:49 PST, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted)
2017-02-04 16:49 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.06 MB, application/zip)
2017-02-04 16:52 PST, Build Bot
no flags Details
Patch (6.03 KB, patch)
2017-02-04 20:30 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-02-04 15:11:39 PST
We don't yet support them.
Comment 1 Radar WebKit Bug Importer 2017-02-04 15:12:16 PST
<rdar://problem/30364784>
Comment 2 zalan 2017-02-04 15:48:08 PST
Created attachment 300642 [details]
Patch
Comment 3 Build Bot 2017-02-04 16:49:08 PST
Comment on attachment 300642 [details]
Patch

Attachment 300642 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3005791

New failing tests:
fast/inline/simple-line-layout-16bit-content.html
fast/text/hyphenate-limit-lines.html
imported/blink/fast/text/international/kana-voiced-sound-marks.html
Comment 4 Build Bot 2017-02-04 16:49:12 PST
Created attachment 300649 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-02-04 16:49:54 PST
Comment on attachment 300642 [details]
Patch

Attachment 300642 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3005746

New failing tests:
fast/inline/simple-line-layout-16bit-content.html
imported/blink/fast/text/international/kana-voiced-sound-marks.html
Comment 6 Build Bot 2017-02-04 16:49:58 PST
Created attachment 300650 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-02-04 16:52:20 PST
Comment on attachment 300642 [details]
Patch

Attachment 300642 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3005796

New failing tests:
fast/inline/simple-line-layout-16bit-content.html
fast/text/hyphenate-limit-lines.html
imported/blink/fast/text/international/kana-voiced-sound-marks.html
Comment 8 Build Bot 2017-02-04 16:52:24 PST
Created attachment 300651 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 zalan 2017-02-04 20:30:33 PST
Created attachment 300657 [details]
Patch
Comment 10 Myles C. Maxfield 2017-02-04 21:29:31 PST
Comment on attachment 300657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300657&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:186
> +        auto characterReasons = canUseForCharacter(character, textIsJustified, includeReasons);

What's the reason for moving this up?
Comment 11 WebKit Commit Bot 2017-02-05 06:42:39 PST
Comment on attachment 300657 [details]
Patch

Clearing flags on attachment: 300657

Committed r211680: <http://trac.webkit.org/changeset/211680>
Comment 12 WebKit Commit Bot 2017-02-05 06:42:45 PST
All reviewed patches have been landed.  Closing bug.