Bug 167820 - Simple line layout: Bail out from Simple Line Layout when the primary font is insufficient.
Summary: Simple line layout: Bail out from Simple Line Layout when the primary font is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-03 16:29 PST by zalan
Modified: 2017-02-03 17:43 PST (History)
10 users (show)

See Also:


Attachments
Patch (8.96 KB, patch)
2017-02-03 16:45 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (9.00 KB, patch)
2017-02-03 17:27 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-02-03 16:29:05 PST
Currently SSL only works with the primary font.
Comment 1 zalan 2017-02-03 16:45:25 PST
Created attachment 300579 [details]
Patch
Comment 2 Myles C. Maxfield 2017-02-03 16:47:30 PST
(In reply to comment #0)
> Currently SSL only works with the primary font.

I think you mean SLL. Pretty sure SSL works with all fonts. 😂
Comment 3 Radar WebKit Bug Importer 2017-02-03 16:47:31 PST
<rdar://problem/30359685>
Comment 4 Myles C. Maxfield 2017-02-03 16:50:39 PST
Comment on attachment 300579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300579&action=review

> Source/WebCore/rendering/SimpleLineLayout.cpp:172
> +        auto glyphData = fontCascade.glyphDataForCharacter(character, false);

reference please
Comment 5 zalan 2017-02-03 17:27:54 PST
Created attachment 300582 [details]
Patch
Comment 6 WebKit Commit Bot 2017-02-03 17:43:40 PST
Comment on attachment 300582 [details]
Patch

Clearing flags on attachment: 300582

Committed r211661: <http://trac.webkit.org/changeset/211661>
Comment 7 WebKit Commit Bot 2017-02-03 17:43:48 PST
All reviewed patches have been landed.  Closing bug.