Bug 167800 – malloc and posix_memalign used without including cstdlib

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[Ting-Wei Lan]

This causes compilation error on FreeBSD:

/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:78:20: error: no member named 'malloc' in the global namespace; did you mean simply 'malloc'?
    void* result = ::malloc(size);
                   ^~~~~~~~
                   malloc
/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:76:18: note: 'malloc' declared here
void* DebugHeap::malloc(size_t size)
                 ^
/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:87:9: error: use of undeclared identifier 'posix_memalign'
    if (posix_memalign(&result, alignment, size)) {
        ^
/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:97:20: error: no member named 'realloc' in the global namespace; did you mean simply 'realloc'?
    void* result = ::realloc(object, size);
                   ^~~~~~~~~
                   realloc
/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:95:18: note: 'realloc' declared here
void* DebugHeap::realloc(void* object, size_t size)
                 ^
/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:105:7: error: no type named 'free' in the global namespace
    ::free(object);
    ~~^
/path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:103:28: warning: unused parameter 'object' [-Wunused-parameter]
void DebugHeap::free(void* object)
                           ^
1 warning and 4 errors generated.

[Ting-Wei Lan]

Created attachment 300543 [details]
mmm

[Ting-Wei Lan]

Created attachment 300544 [details]
Patch

[Geoffrey Garen]

Comment on attachment 300544 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 300544 [details]
Patch

Clearing flags on attachment: 300544

Committed r211651: <http://trac.webkit.org/changeset/211651>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.