Bug 167792 – http/tests/preload/dynamic_removing_preload.html fails to test what it should

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Yoav Weiss]

dynamic_removing_preload is currently not testing what it should.
The test didn't turn on the LinkPreload feature before the latter was turned on by default, which meant is was falsely passing.
The test's failure is also masked by https://bugs.webkit.org/show_bug.cgi?id=167415. Once that is fixed, the test will start to fail.

[Yoav Weiss]

Created attachment 300592 [details]
Patch

[WebKit Commit Bot]

Attachment 300592 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 300592 [details]
Patch

Attachment 300592 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3002668

New failing tests:
http/tests/preload/dynamic_removing_preload.html

[Build Bot]

Created attachment 300617 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Yoav Weiss]

Created attachment 300708 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 300708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300708&action=review

> LayoutTests/TestExpectations:-1048
> -webkit.org/b/167792 http/tests/preload/dynamic_removing_preload.html [ Skip ]

Please use - instead of _ for delimiters.

[Yoav Weiss]

(In reply to comment #6)
> Comment on attachment 300708 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300708&action=review
> 
> > LayoutTests/TestExpectations:-1048
> > -webkit.org/b/167792 http/tests/preload/dynamic_removing_preload.html [ Skip ]
> 
> Please use - instead of _ for delimiters.

I'll change it for this test and all others in a followup patch

[Yoav Weiss]

Comment on attachment 300708 [details]
Patch

Thanks for reviewing! :)

[WebKit Commit Bot]

Comment on attachment 300708 [details]
Patch

Clearing flags on attachment: 300708

Committed r211755: <http://trac.webkit.org/changeset/211755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.