Bug 167790 - Resource usage overlay should be notified when root layer is attached/detached
Summary: Resource usage overlay should be notified when root layer is attached/detached
Status: RESOLVED DUPLICATE of bug 167850
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-02-03 05:25 PST by Carlos Garcia Campos
Modified: 2017-02-05 22:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (14.99 KB, patch)
2017-02-03 05:34 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-03 05:25:49 PST 
Since r211141 we properly destroy and create the overlay root layers when the root layer is attached/detached, but we leave the graphic layers in m_overlayGraphicsLayers alive. They should also be destroyed and created, and their children should e notified too. This is what causes that the resource usage overlay disappears when navigating to another page, and also the reason why it's not shown initially when starting the Mac MiniBrowser and the setting is enabled.
Comment 1 Carlos Garcia Campos 2017-02-03 05:34:59 PST 
Created attachment 300524 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-05 22:53:32 PST 
Comment on attachment 300524 [details]
Patch

This has been fixed in r211683 in a simpler way.
Comment 3 Carlos Garcia Campos 2017-02-05 22:54:08 PST 

*** This bug has been marked as a duplicate of bug 167850 ***