Bug 167785 - JSDOMWindowBase.cpp doesn't build if the JIT is disabled
Summary: JSDOMWindowBase.cpp doesn't build if the JIT is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 167873 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-03 01:47 PST by Alberto Garcia
Modified: 2017-02-06 05:04 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2017-02-03 01:48 PST, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2017-02-03 01:47:06 PST
r211403 moved GetCallerGlobalObjectFunctor from JSDOMBinding.cpp to JSDOMWindowBase.cpp, but forgot to include bytecode/CodeBlock.h in the latter file.

This breaks the build if the JIT is disabled because the headers that would include ClodeBlock.h indirectly are guarded by ENABLE(JIT).

Reproduced with WebKitGTK+ 2.15.4:

Source/WebCore/bindings/js/JSDOMWindowBase.cpp: In member function 'JSC::StackVisitor::Status WebCore::callerDOMWindow(JSC::ExecState*)::GetCallerGlobalObjectFunctor::operator()(JSC::StackVisitor&) const':
Source/WebCore/bindings/js/JSDOMWindowBase.cpp:304:43: error: invalid use of incomplete type 'class JSC::CodeBlock'
                 m_globalObject = codeBlock->globalObject();
Comment 1 Alberto Garcia 2017-02-03 01:48:34 PST
Created attachment 300513 [details]
Patch
Comment 2 Alberto Garcia 2017-02-03 02:25:33 PST
Committed r211624: <http://trac.webkit.org/changeset/211624>
Comment 3 Carlos Garcia Campos 2017-02-06 05:04:17 PST
*** Bug 167873 has been marked as a duplicate of this bug. ***