Bug 167783 - Align URL setters with spec for URLs that cannot be a base URL
Summary: Align URL setters with spec for URLs that cannot be a base URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-03 00:59 PST by Alex Christensen
Modified: 2017-02-03 09:23 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.63 KB, patch)
2017-02-03 01:00 PST, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-02-03 00:59:03 PST 
Align URL setters with spec for URLs that cannot be a base URL
Comment 1 Alex Christensen 2017-02-03 01:00:40 PST 
Created attachment 300511 [details]
Patch
Comment 2 Chris Dumez 2017-02-03 08:41:50 PST 
Comment on attachment 300511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300511&action=review

r=me with a possible improvement suggestion.

> Source/WebCore/html/URLUtils.h:246
>  void URLUtils<T>::setPathname(const String& value)

For the pathname getter above, the spec says:
"If context object’s url’s cannot-be-a-base-URL flag is set, then return context object’s url’s path[0]."

I don't see any special handling in our code, do we really do the right thing?
Comment 3 Alex Christensen 2017-02-03 09:22:34 PST 
I'm not sure, but I'm not touching that code in this patch.  It's possible I'll need to add a check in a future patch to pass a future web platform test.
Comment 4 Alex Christensen 2017-02-03 09:23:26 PST 
http://trac.webkit.org/r211636
Comment 5 Chris Dumez 2017-02-03 09:23:42 PST 
(In reply to comment #3)
> I'm not sure, but I'm not touching that code in this patch.  It's possible
> I'll need to add a check in a future patch to pass a future web platform
> test.

Sure, merely suggesting we look into this in a follow-up.