Bug 167774 – Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic

[Simon Fraser (smfr)]

Created attachment 300489 [details]
Patch

[Build Bot]

Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2995015

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html

[Build Bot]

Created attachment 300490 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2995019

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/tile-cache-zoomed.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html

[Build Bot]

Created attachment 300491 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2995016

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html

[Build Bot]

Created attachment 300492 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2995025

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/tile-cache-zoomed.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html

[Build Bot]

Created attachment 300493 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Created attachment 300497 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 300498 [details]
Patch

[Build Bot]

Comment on attachment 300498 [details]
Patch

Attachment 300498 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2995712

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/tile-cache-zoomed.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html

[Build Bot]

Created attachment 300507 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Simon Fraser (smfr)]

Created attachment 300536 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 300561 [details]
Patch

[WebKit Commit Bot]

Attachment 300561 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:73:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:104:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:118:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 85 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 300561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300561&action=review

> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:155
> +    [mainWebView->platformView() _doAfterNextPresentationUpdate: ^ {

lol, spaces around ^

[Simon Fraser (smfr)]

https://trac.webkit.org/r211662

[Radar WebKit Bug Importer]

<rdar://problem/30467322>