Bug 167774 - Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
Summary: Correctly set the "inWindow" flag for TileControllers that aren't the page ti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-02 19:32 PST by Simon Fraser (smfr)
Modified: 2017-02-10 10:36 PST (History)
9 users (show)

See Also:


Attachments
Patch (68.55 KB, patch)
2017-02-02 19:40 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (911.20 KB, application/zip)
2017-02-02 20:45 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (961.25 KB, application/zip)
2017-02-02 20:47 PST, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.64 MB, application/zip)
2017-02-02 20:53 PST, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (910.58 KB, application/zip)
2017-02-02 21:00 PST, Build Bot
no flags Details
Patch (77.92 KB, patch)
2017-02-02 22:15 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (78.99 KB, patch)
2017-02-02 22:35 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (909.40 KB, application/zip)
2017-02-02 23:54 PST, Build Bot
no flags Details
Patch (84.48 KB, patch)
2017-02-03 09:05 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (86.39 KB, patch)
2017-02-03 13:53 PST, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-02 19:32:01 PST
Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
Comment 1 Simon Fraser (smfr) 2017-02-02 19:40:14 PST
Created attachment 300489 [details]
Patch
Comment 2 Build Bot 2017-02-02 20:44:57 PST
Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2995015

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
Comment 3 Build Bot 2017-02-02 20:45:00 PST
Created attachment 300490 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-02-02 20:47:49 PST
Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2995019

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/tile-cache-zoomed.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
Comment 5 Build Bot 2017-02-02 20:47:52 PST
Created attachment 300491 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-02-02 20:52:57 PST
Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2995016

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
Comment 7 Build Bot 2017-02-02 20:53:01 PST
Created attachment 300492 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-02-02 21:00:23 PST
Comment on attachment 300489 [details]
Patch

Attachment 300489 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2995025

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/tile-cache-zoomed.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
Comment 9 Build Bot 2017-02-02 21:00:27 PST
Created attachment 300493 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Simon Fraser (smfr) 2017-02-02 22:15:35 PST
Created attachment 300497 [details]
Patch
Comment 11 Simon Fraser (smfr) 2017-02-02 22:35:18 PST
Created attachment 300498 [details]
Patch
Comment 12 Build Bot 2017-02-02 23:54:16 PST
Comment on attachment 300498 [details]
Patch

Attachment 300498 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2995712

New failing tests:
compositing/tiling/tiled-layer-resize.html
compositing/tiling/transform-origin-tiled.html
compositing/tiling/tile-cache-zoomed.html
compositing/tiling/rotated-tiled-preserve3d-clamped.html
compositing/tiling/offscreen-tiled-layer.html
compositing/tiling/rotated-tiled-clamped.html
Comment 13 Build Bot 2017-02-02 23:54:20 PST
Created attachment 300507 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 14 Simon Fraser (smfr) 2017-02-03 09:05:17 PST
Created attachment 300536 [details]
Patch
Comment 15 Simon Fraser (smfr) 2017-02-03 13:53:57 PST
Created attachment 300561 [details]
Patch
Comment 16 WebKit Commit Bot 2017-02-03 13:55:25 PST
Attachment 300561 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:73:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:104:  No space between ^ and block definition.  [whitespace/brackets] [4]
ERROR: Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:118:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 3 in 85 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Tim Horton 2017-02-03 14:38:42 PST
Comment on attachment 300561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300561&action=review

> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:155
> +    [mainWebView->platformView() _doAfterNextPresentationUpdate: ^ {

lol, spaces around ^
Comment 18 Simon Fraser (smfr) 2017-02-03 17:55:33 PST
https://trac.webkit.org/r211662
Comment 19 Radar WebKit Bug Importer 2017-02-10 10:36:52 PST
<rdar://problem/30467322>