Bug 167758 - Build libwebrtc and dependencies with Xcode
Summary: Build libwebrtc and dependencies with Xcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 167539 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-02 14:40 PST by Alex Christensen
Modified: 2017-02-02 20:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.22 MB, patch)
2017-02-02 14:41 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.21 MB, patch)
2017-02-02 15:00 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-02-02 14:40:10 PST 
Build libwebrtc and dependencies with Xcode
Comment 1 Alex Christensen 2017-02-02 14:41:10 PST 
Created attachment 300452 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-02 14:43:01 PST 
Attachment 300452 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dean Jackson 2017-02-02 14:44:39 PST 
Comment on attachment 300452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300452&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:14
> +        * Source/webrtc/modules/audio_coding/audio_network_adaptor/mock/untitled folder: Added.

Remove this!!

> Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:52
> +OTHER_LDFLAGS[sdk=macos*] = $(ASAN_OTHER_LDFLAGS) -framework AppKit -lwebrtc -lboringssl;

What is boringssl?
Comment 4 Alex Christensen 2017-02-02 15:00:17 PST 
Created attachment 300455 [details]
Patch
Comment 5 Alex Christensen 2017-02-02 15:32:44 PST 
http://trac.webkit.org/r211602
Comment 6 mitz 2017-02-02 15:48:29 PST 
Can you explain why you changed the debug configuration to not build with DEBUG=1?
Comment 7 mitz 2017-02-02 15:58:17 PST 
Also, the overriding of the C flags from ASAN seems strange.
Comment 8 Alex Christensen 2017-02-02 16:32:56 PST 
I started by copying the ANGLE build files.  This builds and links successfully.  It is entirely likely I overlooked a debug flag
Comment 9 Radar WebKit Bug Importer 2017-02-02 19:33:46 PST 
<rdar://problem/30342855>
Comment 10 Jon Lee 2017-02-02 20:06:12 PST 
*** Bug 167539 has been marked as a duplicate of this bug. ***